Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use WeakPtr to detect deletion to avoid crash on application menu #19558

Merged
merged 1 commit into from
Aug 1, 2019
Merged

fix: use WeakPtr to detect deletion to avoid crash on application menu #19558

merged 1 commit into from
Aug 1, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 31, 2019

Backport of #19257

See that PR for details.

Notes: Fixed crashes when using the application menu.

@trop trop bot requested a review from a team as a code owner July 31, 2019 23:48
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 31, 2019
@trop trop bot mentioned this pull request Jul 31, 2019
Merged
4 tasks
@trop trop bot added 7-0-x backport This is a backport PR labels Jul 31, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 31, 2019
@codebytere codebytere merged commit a960268 into 7-0-x Aug 1, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 1, 2019

Release Notes Persisted

Fixed crashes when using the application menu.

@codebytere codebytere deleted the trop/7-0-x-bp-fix-use-weakptr-to-detect-deletion-to-avoid-crash-on-application-menu-1564616933206 branch August 1, 2019 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
7-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@codebytere